Skip to content

GH-112855: Speed up pathlib.PurePath pickling #112856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 8 commits into from
Apr 20, 2024
Merged

GH-112855: Speed up pathlib.PurePath pickling #112856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5b08580
GH-112855: Speed up `pathlib.PurePath` pickling
barneygale Dec 7, 2023
f4e7ebd
Remove comment that is now invalid.
barneygale Dec 7, 2023
3cb7bbe
Merge branch 'main' into optimise-path-pickle
barneygale Dec 9, 2023
0799d7a
Merge branch 'main' into optimise-path-pickle
barneygale Dec 18, 2023
9720628
Restore part interning, tests changes.
barneygale Dec 18, 2023
49f5c27
Merge branch 'main' into optimise-path-pickle
barneygale Dec 22, 2023
4747a5e
Merge branch 'main' into optimise-path-pickle
barneygale Apr 14, 2024
1ca0037
Remove unnecessary parentheses
barneygale Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Lib/pathlib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,7 @@ def __rtruediv__(self, key):
return NotImplemented

def __reduce__(self):
# Using the parts tuple helps share interned path parts
# when pickling related paths.
return (self.__class__, self.parts)
return self.__class__, tuple(self._raw_paths)

def __repr__(self):
return "{}({!r})".format(self.__class__.__name__, self.as_posix())
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2023-12-07-20-05-54.gh-issue-112855.ph4ehh.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Speed up pickling of :class:`pathlib.PurePath` objects. Patch by Barney
Gale.