gh-112978: Remove redundant condition inside take_gil
#112979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sorry, I don't know this code. Either @corona10 (author of those lines) or @colesbury (no-GIL expert) should review. |
gvanrossum
requested review from
colesbury and
corona10
and removed request for
gvanrossum
WolframAlph
changed the title
take_gil
Contributor
|
The change looks fine to me. |
corona10
reviewed
Dec 11, 2023
Misc/NEWS.d/next/Core and Builtins/2023-12-11-21-33-33.gh-issue-112978.W2c7Xz.rst
Outdated
Show resolved
Hide resolved
WolframAlph
force-pushed
the
remove-redundant-condition
branch
2 times, most recently
from
1c3de23 to
6c011a8
Compare
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-112978: Remove redundant condition inside
take_gil