bpo-35598: IDLE: Update config_key.py with PEP8 names#11330
Merged
terryjreedy merged 5 commits intopython:masterfrom Dec 28, 2018
Merged
bpo-35598: IDLE: Update config_key.py with PEP8 names#11330terryjreedy merged 5 commits intopython:masterfrom
terryjreedy merged 5 commits intopython:masterfrom
Conversation
terryjreedy
reviewed
Dec 28, 2018
Member
|
I found at least one missing '.', so I will be pushing at least that fix. |
terryjreedy
approved these changes
Dec 28, 2018
Member
|
This module makes and immediately places each widgets instead of making a batch and then placing them, as with config dialog. While immediately packing or gridding each widget makes it easy to see that each is places, it makes it harder to compare the options for similar widgets and seeing the geometry structure of the whole frame. So for a non-trivial frame, I think I prefer the other style. I don't think it worthwhile to change it now, but if we were to redo the frame, it might be. |
Contributor
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-11336 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 28, 2018
A few other changes make the code easier to follow. (cherry picked from commit 55698cc) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Dec 28, 2018
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For this first round of modernizing config_key, I tried to limit the changes to converting the existing names to PEP8 names, but there may be a few other changes included to help with following the source.
https://bugs.python.org/issue35598