gh-113803: Fix inaccurate documentation for shutil.move when dst is an existing directory #113837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
docs
serhiy-storchaka
added
needs backport to 3.11
|
Updated the doc and docstring in shutil.py. Do you think it is clear now? @serhiy-storchaka |
terryjreedy
reviewed
Feb 1, 2024
|
Fixed |
|
I believe the last changes satisyfy my request and Serhiy's also, but I leave it to Serhiy to do a final check. |
|
Thanks @daiwt for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 4, 2024
…t is an existing directory (pythonGH-113837) * fix the usage of dst and destination in shutil.move doc * update shutil.move doc (cherry picked from commit da8f9fb) Co-authored-by: Dai Wentao <dwt136@gmail.com>
|
GH-115006 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 4, 2024
…t is an existing directory (pythonGH-113837) * fix the usage of dst and destination in shutil.move doc * update shutil.move doc (cherry picked from commit da8f9fb) Co-authored-by: Dai Wentao <dwt136@gmail.com>
|
GH-115007 is a backport of this pull request to the 3.11 branch. |
terryjreedy
pushed a commit
that referenced
this pull request
Feb 4, 2024
terryjreedy
pushed a commit
that referenced
this pull request
Feb 4, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…t is an existing directory (python#113837) * fix the usage of dst and destination in shutil.move doc * update shutil.move doc
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
…t is an existing directory (python#113837) * fix the usage of dst and destination in shutil.move doc * update shutil.move doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shutil.movewhen dst is an existing directory #113803📚 Documentation preview 📚: https://cpython-previews--113837.org.readthedocs.build/