Skip to content

Conversation

@danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Jan 23, 2024

Fix a typo in contextlib docs in a paragraph that has just been added in #112198
Should be backported to 3.11 and 3.12, since the corresponding backport PRs have already been merged there as well (#114459, #114458)

I verified that the same typo does not appear anywhere else in the repo with git grep statment, and I also ran the contextlib through a spellchecker and did not find further issues.

CC @AA-Turner


📚 Documentation preview 📚: https://cpython-previews--114507.org.readthedocs.build/

@danielhollas danielhollas requested a review from 1st1 as a code owner January 23, 2024 22:38
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Jan 23, 2024
@AA-Turner AA-Turner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 24, 2024
@AA-Turner AA-Turner merged commit 82cd8fe into python:main Jan 24, 2024
@miss-islington-app
Copy link

Thanks @danielhollas for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2024
(cherry picked from commit 82cd8fe)

Co-authored-by: Daniel Hollas <danekhollas@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2024
(cherry picked from commit 82cd8fe)

Co-authored-by: Daniel Hollas <danekhollas@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 24, 2024

GH-114514 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 24, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 24, 2024

GH-114515 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Jan 24, 2024
@danielhollas danielhollas deleted the fix-typos-contextlib branch January 24, 2024 04:23
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants