bpo-35699: fix distuils cannot detect Build Tools 2017 anymore#11495
Merged
ned-deily merged 2 commits intopython:masterfrom Jan 20, 2019
schlamar:patch-1
Merged
bpo-35699: fix distuils cannot detect Build Tools 2017 anymore#11495ned-deily merged 2 commits intopython:masterfrom schlamar:patch-1
ned-deily merged 2 commits intopython:masterfrom
schlamar:patch-1
Conversation
Member
|
@schlamar Looks great. We should have a NEWS entry for this - if you click "details" next to the failed check it'll provide instructions (basically, pip install blurb and add a message like "Fixed detection of Visual Studio Build Tools in distutils") |
Contributor
|
Thanks @schlamar for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-11626 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 20, 2019
…nGH-11495) (cherry picked from commit b2dc4a3) Co-authored-by: Marc Schlaich <marc.schlaich@googlemail.com>
miss-islington
added a commit
that referenced
this pull request
Jan 20, 2019
) (cherry picked from commit b2dc4a3) Co-authored-by: Marc Schlaich <marc.schlaich@googlemail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35699