Docs: mark up NotImplemented using the data role throughout the docs #116135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
added
skip issue
skip news
needs backport to 3.11
erlend-aasland
changed the title
erlend-aasland
removed request for
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
willingc
approved these changes
Feb 29, 2024
Contributor
willingc
left a comment
willingc
left a comment
There was a problem hiding this comment.
LGTM Thanks @erlend-aasland
hugovk
approved these changes
Feb 29, 2024
Contributor
Author
|
Thanks for the review, both of you! |
Contributor
Author
|
I considered fixing all of those constants (Ellipsis, etc.), but I prefer more targeted PRs for the reviewers convenience. |
erlend-aasland
deleted the
docs/markup-notimplemented-in-datamodel-reference
branch
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 29, 2024
pythonGH-116135) (cherry picked from commit dbe44f1) Co-authored-by: Erlend E. Aasland <erlend@python.org>
|
GH-116147 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 29, 2024
pythonGH-116135) (cherry picked from commit dbe44f1) Co-authored-by: Erlend E. Aasland <erlend@python.org>
|
GH-116148 is a backport of this pull request to the 3.11 branch. |
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--116135.org.readthedocs.build/