gh-116393: glob.translate match empty path parts with "**" when recursive=True
#116565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116393
Hello everyone,
this PR makes
glob.translatematch empty path parts (or consecutive path separators, i.e."foo//bar") with"**"whenrecursive=True.When I first implemented the change, I noticed that a pattern that starts with
"**"would also match paths that start with"/", because they start with an 'empty part'.So I added a negative lookahead to the beginning of the regex in case the pattern starts with"**", see: 1624308This preventsglob.translate("**", recursive=True).matchfrom matching"/foo", which is intuitive for me.edit:
"**"matching "/" is in line with pathlibCheers,
Andreas
glob.translate("a/**/c", recursive=True, include_hidden=True)does not match "a//c" #116393