Skip to content

Conversation

@felixxm
Copy link
Contributor

@felixxm felixxm commented Mar 12, 2024

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Mar 12, 2024
@erlend-aasland erlend-aasland changed the title Update broken links in docs. Docs: fix broken links Mar 12, 2024
.. versionadded:: 3.4

**Source code:** :source:`Lib/pathlib.py`
**Source code:** :source:`Lib/pathlib/`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be backported. I can move it to a separate commit or manually prepare PRs for backporting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to fix it in a manual backport.

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JelleZijlstra JelleZijlstra merged commit 3f1b6ef into python:main Mar 13, 2024
@miss-islington-app
Copy link

Thanks @felixxm for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 13, 2024
(cherry picked from commit 3f1b6ef)

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
@miss-islington-app
Copy link

Sorry, @felixxm and @JelleZijlstra, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3f1b6efee95c06f8912bcea4031afacdbc0d5684 3.11

@bedevere-app
Copy link

bedevere-app bot commented Mar 13, 2024

GH-116700 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 13, 2024
@JelleZijlstra
Copy link
Member

@felixxm would you be able to do the manual 3.11 backport?

JelleZijlstra pushed a commit that referenced this pull request Mar 13, 2024
(cherry picked from commit 3f1b6ef)

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
@felixxm felixxm deleted the broken-link-docs branch March 13, 2024 04:39
@bedevere-app
Copy link

bedevere-app bot commented Mar 13, 2024

GH-116701 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 13, 2024
@felixxm
Copy link
Contributor Author

felixxm commented Mar 13, 2024

@felixxm would you be able to do the manual 3.11 backport?

Sure, #116701.

JelleZijlstra pushed a commit that referenced this pull request Mar 13, 2024
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants