gh-116991: Improve pygen --help for python subparser
#116992
Conversation
vasily-v-ryabov
left a comment
vasily-v-ryabov
left a comment
There was a problem hiding this comment.
Thanks for improving it and for the help! I personally started from CPython repository which contains folder Grammar with only python.gram. It would be nice to have python_in_c.gram and python_in_python.gram which makes the picture clear from the very beginning. But this is only my path. Maybe other paths could be improved as well. I didn't see it is well highlighted in Dev Guide.
| "python", | ||
| help=( | ||
| "Generate Python code, needs grammar definition with Python actions, " | ||
| "see `we-like-parsers/pegen`, start with `data/python.gram`" |
There was a problem hiding this comment.
I don't think we should mention that repo. The input for the parser can be any grammar other than the general Python one. We use to generate the meta parser for example. I think linking to another repo it's actually more confusing.
This is also an internal tool without external user guarantees.
I would be on improving the help to mention a bit of this but I still prefer not to link against the original repo
|
I've merged a simple version of |
4 participants
pegen --helpshould mention that it needs different grammar files #116991