Skip to content

bpo-35864: fix namedtuple._asdict() docstring#11720

Merged
rhettinger merged 1 commit intopython:masterfrom
apahim:fix_docstring
Feb 1, 2019
Merged

bpo-35864: fix namedtuple._asdict() docstring#11720
rhettinger merged 1 commit intopython:masterfrom
apahim:fix_docstring

Conversation

@apahim
Copy link
Copy Markdown
Contributor

@apahim apahim commented Feb 1, 2019

Commit 0bb4bdf replaced OrderedDict with regular dict in namedtuple(). This patch just updates the _asdict() docstring.

https://bugs.python.org/issue35864

Signed-off-by: Amador Pahim <apahim@definiens.com>
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Copy Markdown
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please, sign CLA

@rhettinger rhettinger self-assigned this Feb 1, 2019
@rhettinger rhettinger added type-bug An unexpected behavior, bug, or error docs Documentation in the Doc dir skip news labels Feb 1, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @apahim for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

Sorry, @apahim and @rhettinger, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 85d83ec7c99727476c79feb5c34c65264a99144e 3.7

@rhettinger
Copy link
Copy Markdown
Contributor

Thanks for the PR :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants