Skip to content

bpo-35692: pathlib no longer raises when checking file and directory existence#11746

Merged
zooba merged 1 commit intopython:masterfrom
zooba:bpo35692
Feb 4, 2019
Merged

bpo-35692: pathlib no longer raises when checking file and directory existence#11746
zooba merged 1 commit intopython:masterfrom
zooba:bpo35692

Conversation

@zooba
Copy link
Copy Markdown
Member

@zooba zooba commented Feb 3, 2019 •
edited by bedevere-bot
Loading

pathlib no longer raises when checking file and directory existence on drives that are not ready

https://bugs.python.org/issue35692

@zooba zooba added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.7 labels Feb 3, 2019
@zooba zooba requested a review from pitrou February 3, 2019 04:25
pitrou
pitrou approved these changes Feb 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@zooba zooba merged commit 2f6fae6 into python:master Feb 4, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 4, 2019

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@zooba zooba deleted the bpo35692 branch February 4, 2019 07:08
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2019
@zooba @miss-islington
bpo-35692: pathlib no longer raises when checking file and directory …
8af0463 
…existence on drives that are not ready (pythonGH-11746)

(cherry picked from commit 2f6fae6)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 4, 2019

GH-11752 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Feb 4, 2019
@miss-islington @zooba
bpo-35692: pathlib no longer raises when checking file and directory …
69af439 
…existence on drives that are not ready (GH-11746)

(cherry picked from commit 2f6fae6)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

OS-windows type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba @miss-islington @bedevere-bot @pitrou @the-knights-who-say-ni