Skip to content

gh-117215 Make the fromskey() signature match dict.fromkeys(). #117493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 3, 2024
Merged

gh-117215 Make the fromskey() signature match dict.fromkeys(). #117493

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f6c95e
gh-117215 Make the fromskey() signature match dict.fromkeys().
rhettinger Apr 3, 2024
7af30ea
Sync docstring as well.
rhettinger Apr 3, 2024
9d54879
Update Lib/collections/__init__.py
rhettinger Apr 3, 2024
6cc49c4
Merge branch 'main' into fromkeys_signature
rhettinger Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Lib/collections/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,9 +1038,9 @@ def __repr__(self):
return f'{self.__class__.__name__}({", ".join(map(repr, self.maps))})'

@classmethod
def fromkeys(cls, iterable, *args):
'Create a ChainMap with a single dict created from the iterable.'
return cls(dict.fromkeys(iterable, *args))
def fromkeys(cls, iterable, value=None, /):
'Create a new ChainMap with keys from iterable and values set to value.'
return cls(dict.fromkeys(iterable, value))

def copy(self):
'New ChainMap or subclass with a new copy of maps[0] and refs to maps[1:]'
Expand Down