Skip to content

gh-117503: Fix support of non-ASCII user names in posixpath.expanduser() #117504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2024
Merged

gh-117503: Fix support of non-ASCII user names in posixpath.expanduser() #117504

merged 1 commit into from
Apr 17, 2024

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 3, 2024 •
edited by bedevere-app bot
Loading

They are now supported in bytes paths as well as in string paths.

@serhiy-storchaka
pythongh-117503: Fix support of non-ASCII user names in posixpath.exp…
ddbb555 
…anduser()

They are now supported in bytes paths as well as in string paths.
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 only security fixes label Apr 3, 2024
@bedevere-app bedevere-app bot mentioned this pull request Apr 3, 2024
Closed
AlexWaygood
AlexWaygood reviewed Apr 3, 2024
View reviewed changes
@serhiy-storchaka serhiy-storchaka merged commit 51132da into python:main Apr 17, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Apr 17, 2024

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the posixpath-expanduser branch April 17, 2024 09:53
@miss-islington-app
Copy link

miss-islington-app bot commented Apr 17, 2024

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 51132da0c4dac13500d9bb86b2fdad42091d3fd9 3.12

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 17, 2024
@serhiy-storchaka
[3.12] pythongh-117503: Fix support of non-ASCII user names in posixp…
969778a 
…ath.expanduser() (pythonGH-117504)

They are now supported in bytes paths as well as in string paths.
(cherry picked from commit 51132da)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 17, 2024

GH-117970 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 17, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@serhiy-storchaka @diegorusso
pythongh-117503: Fix support of non-ASCII user names in posixpath.exp…
7195565 
…anduser() (pythonGH-117504)

They are now supported in bytes paths as well as in string paths.
serhiy-storchaka added a commit that referenced this pull request Apr 17, 2024
@serhiy-storchaka
[3.12] gh-117503: Fix support of non-ASCII user names in posixpath.ex…
96b29b3 
…panduser() (GH-117504) (GH-117970)

They are now supported in bytes paths as well as in string paths.
(cherry picked from commit 51132da)
@kulikjak
Copy link
Contributor

kulikjak commented Apr 18, 2024

Hi @serhiy-storchaka - the newly added test fails when there are users with a trailing slash in their home path (which I think is allowed?):

======================================================================
FAIL: test_expanduser_pwd2 (test.test_posixpath.PosixPathTest.test_expanduser_pwd2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/.../cpython-3.12/Lib/test/test_posixpath.py", line 344, in test_expanduser_pwd2
    self.assertEqual(posixpath.expanduser('~' + name), home)
AssertionError: '/home/foo' != '/home/foo/'

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Apr 18, 2024

Good catch @kulikjak! Will be fixed in #118056.

@kulikjak
Copy link
Contributor

kulikjak commented Apr 19, 2024

Thank you for the fix - the issue is gone now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

Assignees

@serhiy-storchaka serhiy-storchaka

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka @kulikjak @AlexWaygood