-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
dataclasses docs: add some link anchors #117601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These would be useful to link to in the typing spec.
eendebakpt
approved these changes
Apr 13, 2024
Contributor
eendebakpt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a small suggestion, but looks good
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
hauntsaninja
approved these changes
Apr 14, 2024
|
Thanks @JelleZijlstra for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 14, 2024
(cherry picked from commit c99d374) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
GH-117863 is a backport of this pull request to the 3.12 branch. |
hauntsaninja
pushed a commit
that referenced
this pull request
Apr 14, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These would be useful to link to in the typing spec.
📚 Documentation preview 📚: https://cpython-previews--117601.org.readthedocs.build/