gh-117658: Fix check_dump_traceback_threads in free-threaded build #117659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the GIL disabled, the waiting thread may still be in the `self.running.set() ` call when faulthandler dumps tracebacks.
colesbury
added
skip news
and removed
tests
erlend-aasland
approved these changes
Apr 9, 2024
| ^Thread 0x[0-9a-f]+ \(most recent call first\): | ||
| (?: File ".*threading.py", line [0-9]+ in [_a-z]+ | ||
| ){{1,3}} File "<string>", line 23 in run | ||
| ){{1,3}} File "<string>", line (?:22|23) in run |
Contributor
There was a problem hiding this comment.
It might a bit puzzling to future readers... Perhaps we should add a short comment about this above the regex?
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ild (python#117659) With the GIL disabled, the waiting thread may still be in the `self.running.set() ` call when faulthandler dumps tracebacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the GIL disabled, the waiting thread may still be in the
self.running.set()call when faulthandler dumps tracebacks.check_dump_traceback_threadsin free-threaded build #117658