Tweak wording for dataclasses.replace #117758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
ericvsmith
approved these changes
Apr 12, 2024
erlend-aasland
approved these changes
Apr 13, 2024
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 14, 2024
(cherry picked from commit e7cce2a) Co-authored-by: Gouvernathor <44340603+Gouvernathor@users.noreply.github.com>
|
GH-117876 is a backport of this pull request to the 3.12 branch. |
erlend-aasland
pushed a commit
that referenced
this pull request
Apr 14, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial phrasing mentioned values, when it's actually the keys that are in question.
It also could mean that passing no kwarg at all was invalid, since in that case
**changesdoes not technically specify a field. So, this clarifies thatdataclasses.replace(obj)is a valid way to shallow-clone a dataclass object, even though I didn't write it explicitly.📚 Documentation preview 📚: https://cpython-previews--117758.org.readthedocs.build/