Skip to content

[3.12] gh-117535: Ignore makeup file name "sys" for warnings #118014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2024
Merged

[3.12] gh-117535: Ignore makeup file name "sys" for warnings #118014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11f1dd1
Ignore makeup file name "sys" for warnings
gaogaotiantian Apr 17, 2024
8889326
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 17, 2024
23a26d3
Apply suggestions from code review
JelleZijlstra Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/warnings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ def _formatwarnmsg_impl(msg):
category = msg.category.__name__
s = f"{msg.filename}:{msg.lineno}: {category}: {msg.message}\n"

if msg.line is None:
# "sys" is a made up file name when we are not able to get the frame
# so do not try to get the source line
if msg.line is None and msg.filename != "sys":
try:
import linecache
line = linecache.getline(msg.filename, msg.lineno)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-04-17-23-38-06.gh-issue-117535.4Fgjlq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not try to get the source line for made up file name "sys" in :mod:`warnings`.