bpo-34235: PyArg_ParseTupleAndKeywords: support required keyword arguments#11834
bpo-34235: PyArg_ParseTupleAndKeywords: support required keyword arguments#11834msullivan wants to merge 3 commits intopython:mainfrom
Conversation
…ments This adds a `@` glyph to the PyArg_ParseTupleAndKeywords that specifies that subsequent arguments are required keyword-only arguments. It must appear after `|` and `$`, and allows functions to take all four combinations of positional/named-only v. required/optional arguments. The restriction that `@` only appear after `|` and `$` have already appeared is because it substantially simplifies the state machine and because `$` already only works properly when `|` is specified (though this is not *checked*).
ilevkivskyi
requested review from
larryhastings,
serhiy-storchaka and
vstinner
|
@serhiy-storchaka: Would you mind to review this PR? |
|
I want to try other options first. |
|
I'm working on trying out some of the other options that Serhiy suggested, but have been busy |
iritkatriel
left a comment
iritkatriel
left a comment
There was a problem hiding this comment.
This has merge conflicts now, as well as an unresolved discussion.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
|
I can come back to this if there's any interest, but it wasn't clear to me that anybody wanted this but me |
8 participants
This adds a
@glyph to the PyArg_ParseTupleAndKeywords thatspecifies that subsequent arguments are required keyword-only
arguments. It must appear after
|and$, and allows functions totake all four combinations of positional/named-only
v. required/optional arguments.
The restriction that
@only appear after|and$have alreadyappeared is because it substantially simplifies the state machine and
because
$already only works properly when|is specified (thoughthis is not checked).
https://bugs.python.org/issue34235