Skip to content

bpo-36063: Minor performance tweak in long_divmod()#11915

Merged
serhiy-storchaka merged 1 commit intopython:masterfrom
sir-sigurd:longobject-divmod
Feb 21, 2019
Merged

bpo-36063: Minor performance tweak in long_divmod()#11915
serhiy-storchaka merged 1 commit intopython:masterfrom
sir-sigurd:longobject-divmod

Conversation

@sir-sigurd
Copy link
Copy Markdown
Contributor

@sir-sigurd sir-sigurd commented Feb 18, 2019 •
edited by bedevere-bot
Loading

@sir-sigurd sir-sigurd mentioned this pull request Feb 18, 2019
Closed
serhiy-storchaka
serhiy-storchaka requested changes Feb 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue and provide benchmarking results that show the benefit of this change.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 18, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sir-sigurd sir-sigurd changed the title Minor performance tweak in long_divmod(). bpo-36063: Minor performance tweak in long_divmod() Feb 21, 2019
@sir-sigurd
Copy link
Copy Markdown
Contributor Author

sir-sigurd commented Feb 21, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 21, 2019

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@serhiy-storchaka serhiy-storchaka added performance Performance or resource usage skip news labels Feb 21, 2019
@serhiy-storchaka serhiy-storchaka merged commit ea6207d into python:master Feb 21, 2019
@sir-sigurd sir-sigurd deleted the longobject-divmod branch February 21, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

performance Performance or resource usage skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sir-sigurd @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni