bpo-36117: Allow rich comparisons for real-valued complex objects.#12048
Closed
brandtbucher wants to merge 8 commits intopython:masterfrom
Closed
bpo-36117: Allow rich comparisons for real-valued complex objects.#12048brandtbucher wants to merge 8 commits intopython:masterfrom
brandtbucher wants to merge 8 commits intopython:masterfrom
Conversation
Modifies the built-in complex type to allow rich comparisons if both values being compared are real.
These are pretty exhaustive.
This includes changing 4 test assertions in test_fractions.py.
This includes replacing 4 test assertions in test_decimal.py.
This includes more comprehensive testing of complex comparisons with other numeric types.
Pretty cool!
Don't call float on a float, and clarify a comment.
remilapeyre
suggested changes
Mar 14, 2019
remilapeyre
left a comment
remilapeyre
left a comment
There was a problem hiding this comment.
Hi @brandtbucher the bug related to this pull request was closed as "Not a bug". I think it's best to close this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36117