Skip to content

gh-120726: Fix warnings #120727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2024
Merged

gh-120726: Fix warnings #120727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dd160e
define these functions only in debug build
Eclips4 Jun 19, 2024
3cbb870
Use NDEBUG instead of Py_DEBUG
Eclips4 Jun 19, 2024
4f76c81
...and ifndef instead of ifdef
Eclips4 Jun 19, 2024
4e3b9a5
Update Python/import.c
Eclips4 Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Python/import.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1551,6 +1551,7 @@ get_core_module_dict(PyInterpreterState *interp,
return NULL;
}

#ifndef NDEBUG
static inline int
is_core_module(PyInterpreterState *interp, PyObject *name, PyObject *path)
{
Expand All @@ -1568,7 +1569,6 @@ is_core_module(PyInterpreterState *interp, PyObject *name, PyObject *path)
}


#ifndef NDEBUG
static _Py_ext_module_kind
_get_extension_kind(PyModuleDef *def, bool check_size)
{
Expand Down
7 changes: 4 additions & 3 deletions Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,9 +584,9 @@ free_interpreter(PyInterpreterState *interp)
PyMem_RawFree(interp);
}
}

#ifndef NDEBUG
static inline int check_interpreter_whence(long);

#endif
/* Get the interpreter state to a minimal consistent state.
Further init happens in pylifecycle.c before it can be used.
All fields not initialized here are expected to be zeroed out,
Expand Down Expand Up @@ -1130,7 +1130,7 @@ _PyInterpreterState_IsReady(PyInterpreterState *interp)
return interp->_ready;
}


#ifndef NDEBUG
static inline int
check_interpreter_whence(long whence)
{
Expand All @@ -1142,6 +1142,7 @@ check_interpreter_whence(long whence)
}
return 0;
}
#endif

long
_PyInterpreterState_GetWhence(PyInterpreterState *interp)
Expand Down