Skip to content

gh-120784: Reword utcnow/utcfromtimestamp deprecation warning to use datetime.timezone.utc #120791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nineteendo wants to merge 5 commits into from
Closed

gh-120784: Reword utcnow/utcfromtimestamp deprecation warning to use datetime.timezone.utc #120791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
24e162e
Adjust python implementation
nineteendo Jun 20, 2024
5bc7d91
Adjust C implementation
nineteendo Jun 20, 2024
8b1d141
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 21, 2024
49a0dd1
Mention both
nineteendo Jun 21, 2024
69eaa75
Mention both
nineteendo Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Lib/_pydatetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1811,7 +1811,8 @@ def utcfromtimestamp(cls, t):
warnings.warn("datetime.datetime.utcfromtimestamp() is deprecated and scheduled "
"for removal in a future version. Use timezone-aware "
"objects to represent datetimes in UTC: "
"datetime.datetime.fromtimestamp(t, datetime.UTC).",
"datetime.datetime.fromtimestamp(t, datetime.timezone.utc) or "
"datetime.datetime.fromtimestamp(t, datetime.UTC) when targetting 3.11.",
DeprecationWarning,
stacklevel=2)
return cls._fromtimestamp(t, True, None)
Expand All @@ -1829,7 +1830,8 @@ def utcnow(cls):
warnings.warn("datetime.datetime.utcnow() is deprecated and scheduled for "
"removal in a future version. Use timezone-aware "
"objects to represent datetimes in UTC: "
"datetime.datetime.now(datetime.UTC).",
"datetime.datetime.now(datetime.timezone.utc) or "
"datetime.datetime.now(datetime.UTC) when targetting 3.11.",
DeprecationWarning,
stacklevel=2)
t = _time.time()
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-06-21-19-00-43.gh-issue-120784.w2IUby.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Reword ``utcnow()``/``utcfromtimestamp()`` deprecation warning to use :attr:`datetime.timezone.utc`.
6 changes: 4 additions & 2 deletions Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5454,7 +5454,8 @@ datetime_utcnow(PyObject *cls, PyObject *dummy)
if (PyErr_WarnEx(PyExc_DeprecationWarning,
"datetime.datetime.utcnow() is deprecated and scheduled for removal in a "
"future version. Use timezone-aware objects to represent datetimes "
"in UTC: datetime.datetime.now(datetime.UTC).", 1))
"in UTC: datetime.datetime.now(datetime.timezone.utc) or "
"datetime.datetime.now(datetime.UTC) when targetting 3.11.", 1))
{
return NULL;
}
Expand Down Expand Up @@ -5497,7 +5498,8 @@ datetime_utcfromtimestamp(PyObject *cls, PyObject *args)
if (PyErr_WarnEx(PyExc_DeprecationWarning,
"datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal "
"in a future version. Use timezone-aware objects to represent "
"datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).", 1))
"datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.timezone.utc) or "
"datetime.datetime.fromtimestamp(timestamp, datetime.UTC) when targetting 3.11", 1))
{
return NULL;
}
Expand Down