Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 27, 2024

vstinner and others added 2 commits June 27, 2024 20:56
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@vstinner
Copy link
Member Author

vstinner commented Jul 8, 2024

@gpshead @zooba: Would you mind to review this change?

@zooba
Copy link
Member

zooba commented Jul 10, 2024

PR looks fine to me. I'm still not convinced we should add the function at all though.

@vstinner
Copy link
Member Author

vstinner commented Aug 1, 2024

I failed to convince enough people, I prefer to abandon this function. Let's keep the status quo, os.system().

@vstinner vstinner closed this Aug 1, 2024
@vstinner vstinner deleted the subprocess_shell branch August 1, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants