Skip to content

[docs] fix a Sphinx directive in c-api/object.rst #121430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2024
Merged

[docs] fix a Sphinx directive in c-api/object.rst #121430

merged 1 commit into from
Jul 6, 2024
+1 −0

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Jul 6, 2024 •
edited
Loading

I wouldn't have spotted this one if I wasn't looking at the page by mistake.

Without a new line, this renders as follows (current version)

image

📚 Documentation preview 📚: https://cpython-previews--121430.org.readthedocs.build/en/121430/c-api/object.html#c.Py_GetConstantBorrowed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Jul 6, 2024
@Eclips4 Eclips4 requested a review from vstinner July 6, 2024 16:04
@Eclips4 Eclips4 added needs backport to 3.13 bugs and security fixes skip issue labels Jul 6, 2024
Eclips4
Eclips4 approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vstinner vstinner merged commit ada964f into python:main Jul 6, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 6, 2024

Thanks @picnixz for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2024
@picnixz @miss-islington
[docs] fix a Sphinx directive in c-api/object.rst (pythonGH-121430)
f239988 
(cherry picked from commit ada964f)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 6, 2024

GH-121440 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 6, 2024
vstinner pushed a commit that referenced this pull request Jul 6, 2024
@miss-islington @picnixz
[3.13] [docs] fix a Sphinx directive in c-api/object.rst (GH-121430) (
aae49ec 
#121440)

[docs] fix a Sphinx directive in `c-api/object.rst` (GH-121430)
(cherry picked from commit ada964f)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz picnixz deleted the fix-typo branch July 6, 2024 18:35
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@picnixz @noahbkim
[docs] fix a Sphinx directive in c-api/object.rst (python#121430)
873efb3
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@picnixz @estyxx
[docs] fix a Sphinx directive in c-api/object.rst (python#121430)
8f7c69d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz @Eclips4 @vstinner