Skip to content

gh-122519: Adding socket module shutdown() constants description #122543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 17, 2024
Merged

gh-122519: Adding socket module shutdown() constants description #122543

merged 4 commits into from
Aug 17, 2024
+7 −0

Conversation

@Damien-Chen
Copy link
Contributor

@Damien-Chen Damien-Chen commented Aug 1, 2024 •
edited by bedevere-app bot
Loading

According to ##122519, adding constant argument description for socket.shutdown() method.

📚 Documentation preview 📚: https://cpython-previews--122543.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Aug 1, 2024
@Damien-Chen Damien-Chen changed the title gh-#122519: Adding socket module shutdown() constants description gh-122519: Adding socket module shutdown() constants description Aug 1, 2024
@bedevere-app bedevere-app bot mentioned this pull request Aug 1, 2024
Closed
picnixz
picnixz reviewed Aug 1, 2024
View reviewed changes
@Damien-Chen
Adding socket module shutdown() constants description
ace016e 
Modify some grammar

Adding availability
@Damien-Chen Damien-Chen force-pushed the main branch 2 times, most recently from ace016e to 567ef43 Compare August 1, 2024 11:35
@Damien-Chen Damien-Chen requested a review from picnixz August 1, 2024 13:25
picnixz
picnixz approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny that Sphinx didn't complain about the fact that the constants where not defined previously. I'm ok with those changes but a core dev needs to approve it.

@picnixz
Copy link
Member

picnixz commented Aug 2, 2024

By the way, no need to merge the main branch into your branch. It's better to only merge the main branch if there are conflicts and you need to solve those conflicts (otherwise, I would be notified of such action, thinking that there was an actual change).

@Damien-Chen
Copy link
Contributor Author

Damien-Chen commented Aug 2, 2024

Understood! Sorry I didn`t noticed that.

vadmium
vadmium reviewed Aug 2, 2024
View reviewed changes
@Damien-Chen Damien-Chen requested a review from vadmium August 2, 2024 08:29
vadmium
vadmium reviewed Aug 2, 2024
View reviewed changes
@Damien-Chen Damien-Chen requested a review from vadmium August 2, 2024 09:22
vadmium
vadmium approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@vadmium vadmium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Damien-Chen
Copy link
Contributor Author

Damien-Chen commented Aug 10, 2024

Should we merge this ?

@kumaraditya303 kumaraditya303 added the needs backport to 3.12 only security fixes label Aug 17, 2024
@kumaraditya303 kumaraditya303 added the needs backport to 3.13 bugs and security fixes label Aug 17, 2024
@kumaraditya303 kumaraditya303 merged commit 8a59dec into python:main Aug 17, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Aug 17, 2024

Thanks @Damien-Chen for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 17, 2024
@Damien-Chen @miss-islington
pythongh-122519: Adding socket module shutdown() constants description (
3008087 
pythonGH-122543)

(cherry picked from commit 8a59dec)

Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 17, 2024

GH-123093 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 17, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 17, 2024
@Damien-Chen @miss-islington
pythongh-122519: Adding socket module shutdown() constants description (
9b18d7f 
pythonGH-122543)

(cherry picked from commit 8a59dec)

Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 17, 2024

GH-123094 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Aug 17, 2024
kumaraditya303 pushed a commit that referenced this pull request Aug 17, 2024
@miss-islington @Damien-Chen
[3.12] gh-122519: Adding socket module shutdown() constants descripti…
28f3770 
…on (GH-122543) (#123094)

gh-122519: Adding socket module shutdown() constants description (GH-122543)
(cherry picked from commit 8a59dec)

Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>
kumaraditya303 pushed a commit that referenced this pull request Aug 17, 2024
@miss-islington @Damien-Chen
[3.13] gh-122519: Adding socket module shutdown() constants descripti…
2620c15 
…on (GH-122543) (#123093)

gh-122519: Adding socket module shutdown() constants description (GH-122543)
(cherry picked from commit 8a59dec)

Co-authored-by: Damien <81557462+Damien-Chen@users.noreply.github.com>
jeremyhylton pushed a commit to jeremyhylton/cpython that referenced this pull request Aug 19, 2024
@Damien-Chen @jeremyhylton
pythongh-122519: Adding socket module shutdown() constants description (
68fe1a1 
python#122543)
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@Damien-Chen @blhsing
pythongh-122519: Adding socket module shutdown() constants description (
547c6fa 
python#122543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadmium vadmium vadmium approved these changes

@picnixz picnixz picnixz approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Damien-Chen @picnixz @vadmium @kumaraditya303