Skip to content

Conversation

@cfbolz
Copy link
Contributor

@cfbolz cfbolz commented Aug 24, 2024

if no f_in and f_out arguments are given, _ReadlineWrapper calls os.dup on fd 0 and 1. Instead, just pass None, because the fds aren't needed anyway in this test.

if no f_in and f_out arguments are given, _ReadlineWrapper calls os.dup
on fd 0 and 1. Instead, just pass None, because the fds aren't needed
anyway in this test
@hauntsaninja hauntsaninja added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting merge labels Aug 24, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hauntsaninja for commit 20eb346 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 24, 2024
@hauntsaninja hauntsaninja added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 24, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hauntsaninja for commit 20eb346 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 24, 2024
@cfbolz
Copy link
Contributor Author

cfbolz commented Aug 25, 2024

ok, the refleak builds worked, the failures look unrelated. @hauntsaninja, I don't know what the usual approach is in such a situation? the commit definitely improves the buildbot situation.

@pablogsal pablogsal merged commit aa90592 into python:main Aug 25, 2024
@pablogsal
Copy link
Member

ok, the refleak builds worked, the failures look unrelated. @hauntsaninja, I don't know what the usual approach is in such a situation? the commit definitely improves the buildbot situation.

Let's land it and back port it

@pablogsal pablogsal added the needs backport to 3.13 bugs and security fixes label Aug 25, 2024
@miss-islington-app
Copy link

Thanks @cfbolz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2024
…-123302)

(cherry picked from commit aa90592)

Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
@bedevere-app
Copy link

bedevere-app bot commented Aug 25, 2024

GH-123313 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 25, 2024
@cfbolz
Copy link
Contributor Author

cfbolz commented Aug 25, 2024

@pablogsal thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants