Skip to content

Change WriterObj.writeline to WriterObj.write#12344

Merged
miss-islington merged 1 commit into
python:masterfrom
remilapeyre:simplify-csv-naming
May 14, 2019
Merged

Change WriterObj.writeline to WriterObj.write#12344
miss-islington merged 1 commit into
python:masterfrom
remilapeyre:simplify-csv-naming

Conversation

@remilapeyre
Copy link
Copy Markdown

This cleans the csv module a bit, I don't think it requires a bpo issue or a news entry.

@csabella
Copy link
Copy Markdown
Contributor

@remilapeyre, this isn't a trivial issue, so it would require a bpo issue. Thanks!

@asvetlov
Copy link
Copy Markdown
Contributor

Usually, we discourage PRs like this: it just renames the internal name without providing any extra functionality or bug fixing.

@csabella
Copy link
Copy Markdown
Contributor

@remilapeyre, thank you for the suggestion, but I'l close this based on @asvetlov's comment.

@csabella csabella closed this May 14, 2019
@remilapeyre
Copy link
Copy Markdown
Author

Hi @asvetlov, @csabella ! It was asked by @vstinner in #12306 (comment) as the previous naming was misleading.

@asvetlov
Copy link
Copy Markdown
Contributor

Ok, I'm fine then.
Sorry, without the context your motivation was not very clear.

@miss-islington
Copy link
Copy Markdown
Contributor

@remilapeyre: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 2bc158f into python:master May 14, 2019
@asvetlov
Copy link
Copy Markdown
Contributor

Thanks, @remilapeyre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants