[3.6] bpo-35155: clarify protocol handler method naming (GH-10313)#12503
Closed
miss-islington wants to merge 1 commit intopython:3.6from
Closed
[3.6] bpo-35155: clarify protocol handler method naming (GH-10313)#12503miss-islington wants to merge 1 commit intopython:3.6from
miss-islington wants to merge 1 commit intopython:3.6from
Conversation
Clarify that the naming of protocol handler methods shouldn't be literally called "protocol" but should be named after the actual protocol. https://bugs.python.org/issue35155 (cherry picked from commit dd7c4ce) Co-authored-by: Denton Liu <liu.denton+github@gmail.com>
orsenthil
approved these changes
Mar 22, 2019
Contributor
Author
|
@Denton-L: Status check is done, and it's a success ✅ . |
Contributor
Author
|
Sorry, I can't merge this PR. Reason: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that the naming of protocol handler methods shouldn't be literally called "protocol" but should be named after the actual protocol.
https://bugs.python.org/issue35155
(cherry picked from commit dd7c4ce)
Co-authored-by: Denton Liu liu.denton+github@gmail.com
https://bugs.python.org/issue35155