gh-125435: Add total_seconds() method to datetime.time #125433
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
MirrorAzure
changed the title
| @@ -0,0 +1 @@ | |||
| Add :meth:`datetime.time.total_seconds` method | |||
There was a problem hiding this comment.
You'll need to add a corresponding documentation entry for this one.
| def fold(self): | ||
| return self._fold | ||
|
|
||
| def total_seconds(self): |
There was a problem hiding this comment.
- You should also update the C implementation.
- You should add tests.
- You should check corner cases where the arithmetic may be a fuzzy.
|
|
||
| def total_seconds(self): | ||
| """Total seconds in the time.""" | ||
| return ((self.hour * 3600 + self.minute * 60 + self.second) * 10**6 + |
There was a problem hiding this comment.
I don't think the multiply and divide operation is needed. You should write:
return self.hour * 3600 + self.minute * 60 + self.second + self.microsecond / 1e6
|
Closing per #125435 (comment). |
3 participants
A method similar to datetime.timedelta.total_seconds()
Returns total seconds of time object