Skip to content

gh-125435: Add total_seconds() method to datetime.time #125433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

gh-125435: Add total_seconds() method to datetime.time #125433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4eda1ba
Add total_seconds() method to datetime.time
MirrorAzure Oct 14, 2024
c8bf840
refactor: Fix trailing whitespaces
MirrorAzure Oct 14, 2024
1b97bce
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Lib/_pydatetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1392,6 +1392,7 @@ class time:
utcoffset()
tzname()
dst()
total_seconds()

Properties (readonly):
hour, minute, second, microsecond, tzinfo, fold
Expand Down Expand Up @@ -1473,6 +1474,11 @@ def tzinfo(self):
def fold(self):
return self._fold

def total_seconds(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You should also update the C implementation.
  2. You should add tests.
  3. You should check corner cases where the arithmetic may be a fuzzy.

"""Total seconds in the time."""
return ((self.hour * 3600 + self.minute * 60 + self.second) * 10**6 +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the multiply and divide operation is needed. You should write:

return self.hour * 3600 + self.minute * 60 + self.second + self.microsecond / 1e6

self.microsecond) / 10**6

# Standard conversions, __hash__ (and helpers)

# Comparisons of time objects with other.
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-10-14-08-20-18.gh-issue-125435.0bB-44.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add :meth:`datetime.time.total_seconds` method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add a corresponding documentation entry for this one.

Loading