Skip to content

Conversation

@jude253
Copy link

@jude253 jude253 commented Nov 17, 2024

I added a retry decorator to functools, written in pure python so it should be maximally portable. I also added unit tests covering all aspects of the functionality. This is something I have been wishing to have for years and I explain in this issue: #126927

It has some keyword arguments that can be configured for different retry behavior and smart defaults.

This is my first contribution to CPython and I would really appreciate any feedback or pointers to add this change.

Tests

  • I ran ./python -m unittest Lib/test/test_functools.py -v with no errors
    • I ensured that the new tests I wrote work
  • I ran make patchcheck successfully

@jude253 jude253 requested a review from rhettinger as a code owner November 17, 2024 09:15
@ghost
Copy link

ghost commented Nov 17, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 17, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@terryjreedy
Copy link
Member

Closing until issue is re-opened.

@jude253
Copy link
Author

jude253 commented Nov 17, 2024

Thanks! I will try to gather buy in for this feature at some point. I appreciate the eyes on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants