gh-126927: Add functools.retry decorator function #126943
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Past PR: #126928
NEW PR NOTE: I added updates to the past PR that I raised such as formatting the code and adding news/whats new. I do not have time at the moment to have a discussion about adding this feature, so I will mark this PR as a draft, then update the description and publish this review after.
I added a
retrydecorator tofunctools, written in pure python so it should be maximally portable. I also added unit tests covering all aspects of the functionality. This is something I have been wishing to have for years and I explain in this issue: #126927It has some keyword arguments that can be configured for different retry behavior and smart defaults.
This is my first contribution to CPython and I would really appreciate any feedback or pointers to add this change.
Tests
./python -m unittest Lib/test/test_functools.py -vwith no errorsmake patchchecksuccessfully📚 Documentation preview 📚: https://cpython-previews--126943.org.readthedocs.build/