Skip to content

[3.7] bpo-35726: Prevented QueueHandler formatting from affecting other handlers (GH-11537) #12716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ned-deily merged 1 commit into from
May 2, 2019
Merged

[3.7] bpo-35726: Prevented QueueHandler formatting from affecting other handlers (GH-11537) #12716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/logging/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from stat import ST_DEV, ST_INO, ST_MTIME
import queue
import threading
import copy

#
# Some constants...
Expand Down Expand Up @@ -1377,6 +1378,8 @@ def prepare(self, record):
# exc_info and exc_text attributes, as they are no longer
# needed and, if not None, will typically not be pickleable.
msg = self.format(record)
# bpo-35726: make copy of record to avoid affecting other handlers in the chain.
record = copy.copy(record)
record.message = msg
record.msg = msg
record.args = None
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2019-01-13-01-33-00.bpo-35726.dasdas.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
QueueHandler.prepare() now makes a copy of the record before modifying and enqueueing it, to avoid affecting other handlers in the chain.