Skip to content

gh-76075: Correct datetime.timestamp documentation #131202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2025
Merged

gh-76075: Correct datetime.timestamp documentation #131202

merged 3 commits into from
May 20, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Mar 13, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 13, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Mar 13, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 13, 2025
Open
@StanFromIreland
Copy link
Member Author

StanFromIreland commented May 19, 2025

@pganssle Friendly ping, maybe you could review ... ?

pganssle
pganssle requested changes May 20, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland
Copy link
Member Author

StanFromIreland commented May 20, 2025

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from pganssle May 20, 2025 15:57
pganssle
pganssle requested changes May 20, 2025
View reviewed changes
Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, minor nitpick.

@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland
Copy link
Member Author

StanFromIreland commented May 20, 2025

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from pganssle May 20, 2025 16:09
pganssle
pganssle approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Stan!

@pganssle pganssle merged commit 86397cf into python:main May 20, 2025
29 of 32 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs May 20, 2025
@StanFromIreland StanFromIreland deleted the mktime-doc branch May 20, 2025 16:21
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@StanFromIreland @lkollar
pythongh-76075: Correct datetime.timestamp documentation (python#13…
31ba909 
…1202)

* Clean up timestamp docs

* Update datetime.rst

* Suggestion
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@StanFromIreland @Pranjal095
pythongh-76075: Correct datetime.timestamp documentation (python#13…
d76817f 
…1202)

* Clean up timestamp docs

* Update datetime.rst

* Suggestion
@brianschubert
Copy link
Member

brianschubert commented Jul 16, 2025

Do we want this backported to 3.13/3.14?

@brianschubert brianschubert mentioned this pull request Jul 16, 2025
Closed
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@StanFromIreland @taegyunkim
pythongh-76075: Correct datetime.timestamp documentation (python#13…
2747801 
…1202)

* Clean up timestamp docs

* Update datetime.rst

* Suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle pganssle approved these changes

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @brianschubert @pganssle