Skip to content

Docs: Use python -m pip install everywhere#13257

Merged
brettcannon merged 2 commits intopython:masterfrom
bsolomon1124:python-m-pip-usage
Jun 21, 2019
Merged

Docs: Use python -m pip install everywhere#13257
brettcannon merged 2 commits intopython:masterfrom
bsolomon1124:python-m-pip-usage

Conversation

@bsolomon1124
Copy link
Copy Markdown
Contributor

@bsolomon1124 bsolomon1124 commented May 12, 2019

Follows a similar recent Django ticket:

https://code.djangoproject.com/ticket/30367

Quoting from that ticket/PR:

Using python -m pip install foo makes sure the copy of pip looked up and executed is the one installed for the interpreter copy currently in use (be it a system-wide or a virtualenv's).

This is not technically needed in a virtualenv, but the idea here is consistency: pick a single option that works everywhere and be consistent about it.

Follows a similar recent Django ticket:

> https://code.djangoproject.com/ticket/30367

Quoting from that ticket/PR:

> Using ``python -m pip install foo`` makes sure the copy of
> pip looked up and executed is the one installed for the
> interpreter copy currently in use (be it a system-wide
> or a virtualenv's).

This is not technically needed in a virtualenv, but the idea here
is consistency: pick a single option that works everywhere and
be consistent about it.
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 12, 2019
@csabella csabella requested a review from brettcannon May 13, 2019 02:55
Copy link
Copy Markdown
Contributor

@BoboTiG BoboTiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bsolomon1124, I am +1 for those changes.

Copy link
Copy Markdown
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment explaining that the

Comment thread Doc/howto/pyporting.rst
@bedevere-bot
Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bsolomon1124
Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@brettcannon brettcannon self-requested a review June 3, 2019 22:03
@brettcannon
Copy link
Copy Markdown
Member

Thanks!

@bsolomon1124 bsolomon1124 deleted the python-m-pip-usage branch June 21, 2019 19:49
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
…13257)

This is to help prevent people from accidentally installing into the wrong Python interpreter if they are not aware of which Python interpreter `pip` points to.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
…13257)

This is to help prevent people from accidentally installing into the wrong Python interpreter if they are not aware of which Python interpreter `pip` points to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants