Skip to content

bpo-36567: use debian's manpage service for references#13339

Merged
berkerpeksag merged 2 commits intopython:masterfrom
isidentical:bpo36567
May 18, 2019
Merged

bpo-36567: use debian's manpage service for references#13339
berkerpeksag merged 2 commits intopython:masterfrom
isidentical:bpo36567

Conversation

@isidentical
Copy link
Copy Markdown
Member

@isidentical isidentical commented May 15, 2019

use MANPAGES_URL env variable for manpage references. If that variable not found, use debians manpage service.

https://bugs.python.org/issue36567

Comment thread Misc/NEWS.d/next/Documentation/2019-05-15-14-31-40.bpo-36567.MNbyoI.rst Outdated
Comment thread Doc/conf.py Outdated
Comment thread Doc/conf.py Outdated
@bedevere-bot
Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@isidentical
Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

Copy link
Copy Markdown
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just tested this branch locally and it worked as expected.

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @isidentical for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @isidentical for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

Sorry, @isidentical and @berkerpeksag, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker eab99650799699f766c2660f4cfa8ff3f9e8457f 3.7

@berkerpeksag
Copy link
Copy Markdown
Member

Ok, let's not bother backporting to 3.7 then.

@berkerpeksag berkerpeksag removed their assignment May 19, 2019
@isidentical isidentical deleted the bpo36567 branch December 7, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants