Skip to content

Fix typo in _PyMethodDef_RawFastCallKeywords error message#13343

Merged
matrixise merged 1 commit intopython:masterfrom
jdemeyer:RawFastCallKeywords_typo
May 17, 2019
Merged

Fix typo in _PyMethodDef_RawFastCallKeywords error message#13343
matrixise merged 1 commit intopython:masterfrom
jdemeyer:RawFastCallKeywords_typo

Conversation

@jdemeyer
Copy link
Copy Markdown
Contributor

@jdemeyer jdemeyer commented May 15, 2019 •
edited
Loading

skip news and skip issue because it's a triviality.

matrixise
matrixise approved these changes May 15, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@matrixise
Copy link
Copy Markdown
Member

matrixise commented May 17, 2019

@jdemeyer I think we need this PR for 3.7, do you confirm?

@jdemeyer
Copy link
Copy Markdown
Contributor Author

jdemeyer commented May 17, 2019

I think we need this PR for 3.7, do you confirm?

I doesn't matter that much. But sure, why not?

@matrixise matrixise merged commit a8b4694 into python:master May 17, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 17, 2019

Thanks @jdemeyer for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@matrixise
Copy link
Copy Markdown
Member

matrixise commented May 17, 2019

Thank you @jdemeyer for your contribution.

matrixise pushed a commit to matrixise/cpython that referenced this pull request May 17, 2019
@jdemeyer @matrixise
[3.7] Fix typo in _PyMethodDef_RawFastCallKeywords error message (pyt…
6519565 
…honGH-13343)

(cherry picked from commit a8b4694)

Co-authored-by: Jeroen Demeyer <J.Demeyer@UGent.be>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 17, 2019

GH-13385 is a backport of this pull request to the 3.7 branch.

matrixise added a commit that referenced this pull request May 17, 2019
@matrixise @jdemeyer
[3.7] Fix typo in _PyMethodDef_RawFastCallKeywords error message (GH-…
9050aaf 
…13343) (GH-13385)

(cherry picked from commit a8b4694)

Co-authored-by: Jeroen Demeyer <J.Demeyer@UGent.be>
@matrixise
Copy link
Copy Markdown
Member

matrixise commented May 17, 2019

@jdemeyer the backport has been merged, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matrixise matrixise matrixise approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jdemeyer @matrixise @miss-islington @bedevere-bot @the-knights-who-say-ni