pathlib ABCs: check filename validity when copying#139005
Draft
barneygale wants to merge 2 commits intopython:mainfrom
Draft
pathlib ABCs: check filename validity when copying#139005barneygale wants to merge 2 commits intopython:mainfrom
barneygale wants to merge 2 commits intopython:mainfrom
Conversation
Use `target_path.joinpath('_').with_name(source_name)` to generate child
paths in a target directory when copying. This formula ensures `ValueError`
is raised if the filename is invalid for the target path type (e.g. empty
or contains a path separator.)
No change of public behaviour because `pathlib.Path` is the only exposed
implementation of `ReadablePath`, and validity issues arise only when the
source and target path parsers differ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
target_path.joinpath('_').with_name(source_name)to generate child paths in a target directory when copying. This formula ensuresValueErroris raised if the filename is invalid for the target path type (e.g. empty or contains a path separator.)No change of public behaviour because
pathlib.Pathis the only exposed implementation ofReadablePath, and validity issues arise only when the source and target path parsers differ.