-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
gh-101100: fix sphinx warnings in library/signal.rst
#139930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ZeroIntensity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
! syntax should be reserved for actual Python APIs that we haven't documented, not for Unix APIs that aren't part of Python at all. Please make these an inline codeblock instead.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again Should I add these changes to document of |
|
Thanks for making the requested changes! @ZeroIntensity: please review the changes made to this pull request. |
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
Thanks @LamentXU123 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…honGH-139930) (cherry picked from commit 447c7a8) Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
…honGH-139930) (cherry picked from commit 447c7a8) Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
|
GH-139966 is a backport of this pull request to the 3.14 branch. |
|
GH-139967 is a backport of this pull request to the 3.13 branch. |
siginfo_tstructure. In libraryoswe also mentioned this structure in functionwaitid:So I just suppress all of them, similar to how we did in
os.rst📚 Documentation preview 📚: https://cpython-previews--139930.org.readthedocs.build/