Skip to content

[3.8] Make asyncio stream sendfile fail on error (was hang) (GH-14025) #14026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Jun 12, 2019
Merged

[3.8] Make asyncio stream sendfile fail on error (was hang) (GH-14025) #14026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions Lib/test/test_asyncio/test_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1656,22 +1656,25 @@ def test_sendfile(self):

async def serve_callback(stream):
data = await stream.readline()
self.assertEqual(data, b'begin\n')
await stream.write(b'ack-' + data)
data = await stream.readline()
self.assertEqual(data, b'data\n')
await stream.write(b'ack-' + data)
data = await stream.readline()
self.assertEqual(data, b'end\n')
await stream.write(b'done\n')
await stream.write(b'ack-' + data)
await stream.close()

async def do_connect(host, port):
stream = await asyncio.connect(host, port)
await stream.write(b'begin\n')
data = await stream.readline()
self.assertEqual(b'ack-begin\n', data)
with open(support.TESTFN, 'rb') as fp:
await stream.sendfile(fp)
data = await stream.readline()
self.assertEqual(b'ack-data\n', data)
await stream.write(b'end\n')
data = await stream.readline()
self.assertEqual(data, b'done\n')
self.assertEqual(data, b'ack-end\n')
await stream.close()

async def test():
Expand Down