gh-125434: Display thread name in faulthandler on Windows #140675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
requested review from
ZeroIntensity and
ericsnowcurrently
as code owners
|
Calling OpenThread(), GetThreadDescription() and _Py_EncodeLocaleRaw() is not async signal-safe. For example, _Py_EncodeLocaleRaw() allocates memory on the heap memory. But on Windows, signal handlers are called in a temporary thread. So it should be ok to call these functions in faulthandler signal handlers. |
|
Ok, let's see how it goes. Merged, thanks for reviews. I'm not confident in this code, so I prefer to not backport it to 3.14.1. Also, it can be seen as a new feature rather than a bugfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.