Skip to content

[3.9] gh-98793: Fix typecheck in overlapped.c (GH-98835) (GH-98890) #140825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

[3.9] gh-98793: Fix typecheck in overlapped.c (GH-98835) (GH-98890) #140825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
561bd00
[3.9] gh-98793: Fix typecheck in `overlapped.c` (GH-98835) (GH-98890)
CharlieZhao95 Oct 31, 2022
97e53c4
Switch overlapped_WSAConnect() and Overlapped_WSASendTo() to METH_FAS…
ambv Oct 31, 2025
0cbe5e4
Minimize diff: use METH_VARARGS again
encukou Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Lib/test/test_asyncio/test_windows_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,17 @@ def threadMain():
stop.set()
thr.join()

def test_address_argument_type_error(self):
# Regression test for https://github.com/python/cpython/issues/98793
proactor = self.loop._proactor
sock = socket.socket(type=socket.SOCK_DGRAM)
bad_address = None
with self.assertRaises(TypeError):
proactor.connect(sock, bad_address)
with self.assertRaises(TypeError):
proactor.sendto(sock, b'abc', addr=bad_address)
sock.close()


class WinPolicyTests(WindowsEventsTestCase):

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-10-29-03-40-18.gh-issue-98793.WSPB4A.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix argument typechecks in :func:`!_overlapped.WSAConnect` and :func:`!_overlapped.Overlapped.WSASendTo` functions.
8 changes: 5 additions & 3 deletions Modules/overlapped.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1552,7 +1552,9 @@ overlapped_WSAConnect(PyObject *self, PyObject *args)
int Length;
int err;

if (!PyArg_ParseTuple(args, F_HANDLE "O", &ConnectSocket, &AddressObj)) {

if (!PyArg_ParseTuple(args, F_HANDLE "O!:WSAConnect",
&ConnectSocket, &PyTuple_Type, &AddressObj)) {
return NULL;
}

Expand Down Expand Up @@ -1598,8 +1600,8 @@ Overlapped_WSASendTo(OverlappedObject *self, PyObject *args)
int ret;
DWORD err;

if (!PyArg_ParseTuple(args, F_HANDLE "O" F_DWORD "O",
&handle, &bufobj, &flags, &AddressObj))
if (!PyArg_ParseTuple(args, F_HANDLE "OkO!:WSASendTo",
&handle, &bufobj, &flags, &PyTuple_Type, &AddressObj))
{
return NULL;
}
Expand Down
Loading