-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
gh-139741: Make dist-pdf docs archive build work for macOS
#140837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming it works on MacOS 26.0.1, thank you, sharing one concern
``getconf _NPROCESSORS_ONLN`` is available in both Linux and macOS, but ``nproc`` is not. This change prevents the build from breaking again if macOS ever upgrades its `make` to version 4 or above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, confirmed this is working* on macOS.
* I don't have latexmk installed, but the commands are being called as expected.
Building docs archive in pdf format on macOS is currently unsuccessful. This PR fixes it.
Changes:
--output-syncon macOS, as macOS'smakedoes not yet support the output sync feature.nprocby default; usegetconf _NPROCESSORS_ONLNinstead.Thanks @m-aciek for providing the initial solution and PR suggestion.
📚 Documentation preview 📚: https://cpython-previews--140837.org.readthedocs.build/