Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Lib/test/test_audit.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,14 @@ def test_time_fail(self):
self.assertNotEqual(returncode, 0)
self.assertIn('hook failed', stderr.splitlines()[-1])

def test_time_leak(self):
import sys
import time # Leaks struct_time_type

hook = lambda a, b: None
sys.addaudithook(hook)
t = time.localtime()

def test_sys_monitoring_register_callback(self):
returncode, events, stderr = self.run_python("test_sys_monitoring_register_callback")
if returncode:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix memory leak where modules that create types during initialization
leak those types when audit hooks are active.
3 changes: 3 additions & 0 deletions Python/pylifecycle.c
Original file line number Diff line number Diff line change
Expand Up @@ -2251,6 +2251,9 @@ _Py_Finalize(_PyRuntimeState *runtime)
*/
PyGC_Collect();

/* Clear audit hooks before destroying modules to avoid reference cycles */
Py_CLEAR(tstate->interp->audit_hooks);

/* Destroy all modules */
_PyImport_FiniExternal(tstate->interp);
finalize_modules(tstate);
Expand Down
Loading