[3.14] gh-140826 Remove the wrong documents about comparison behavior on winreg.HKEYType #140999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aisk
changed the title
aisk
changed the title
serhiy-storchaka
approved these changes
Nov 4, 2025
| "Operations:\n" | ||
| "__bool__ - Handles with an open object return true, otherwise false.\n" | ||
| "__int__ - Converting a handle to an integer returns the Win32 handle.\n" | ||
| "rich comparison - Handle objects are compared using the handle value."); |
There was a problem hiding this comment.
We need to update this in main too. Maybe use __eq__?
There was a problem hiding this comment.
Hi, thank you for your review. The docstring for this module is missing a few other functions (the DeleteTree) as well, besides this one, I’ll make a PR to sync them all tomorrow.
|
Thanks @aisk for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 4, 2025
…havior on winreg.HKEYType (pythonGH-140999) (cherry picked from commit c3f9702) Co-authored-by: AN Long <aisk@users.noreply.github.com>
|
GH-141003 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--140999.org.readthedocs.build/
winreg.HKEYTypeis inconsistent with its documentation #140826