Skip to content

gh-141004: deprecate Py_MATH_El and Py_MATH_PIl macros #141035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-141004: deprecate Py_MATH_El and Py_MATH_PIl macros #141035

wants to merge 4 commits into from

Conversation

@skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Nov 5, 2025 •
edited by github-actions bot
Loading

@skirpichev skirpichev requested a review from AA-Turner as a code owner November 5, 2025 02:54
@bedevere-app bedevere-app bot mentioned this pull request Nov 5, 2025
Open
@skirpichev
Copy link
Contributor Author

skirpichev commented Nov 5, 2025

CC @ZeroIntensity, @vstinner

vstinner
vstinner reviewed Nov 5, 2025
View reviewed changes
@skirpichev @vstinner
Apply suggestions from code review
fd0ebd8 
Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner
Copy link
Member

vstinner commented Nov 5, 2025

A code search in PyPI top 15,000 found no matching line:

$ ./search_pypi_top.py PYPI-2025-09-22/ 'Py_MATH_PIl|Py_MATH_El' -o Py_MATH_PIl -q

Time: 0:01:39.505584
Found 0 matching lines in 0 projects
Output written into: Py_MATH_PIl

vstinner
vstinner approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZeroIntensity
ZeroIntensity approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev @vstinner @ZeroIntensity