-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
gh-141004: document Py_INFINITY macro #141145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| .. deprecated:: 3.15 | ||
| The macro is soft deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this note so we can backport this, and then #141033 will add it back (for 3.15 only) once the C API WG approves the deprecation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to backport depreciation, if it will be approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, deprecations are not backported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not aware of anyone else doing that. Do you know of a deprecation being backported to older versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know of a deprecation being backported to older versions?
E.g.: #124386.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, in that case, I'm fine with backporting #141033, but we should still remove the note from this PR if we want to land it soon, since the C API WG hasn't approved deprecating anything yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with backporting #141033
No, that pr is not going to be backported, only docs here.
we should still remove the note from this PR if we want to land it soon
No need to rush. Lets wait decision. Then we could merge this pr (with or without the deprecation and then, maybe, the #141033 - which might be rejected)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
| .. deprecated:: 3.15 | ||
| The macro is soft deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .. deprecated:: 3.15 | |
| The macro is soft deprecated. |
📚 Documentation preview 📚: https://cpython-previews--141145.org.readthedocs.build/