Skip to content

Conversation

@skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Nov 6, 2025

Comment on lines +86 to +87
.. deprecated:: 3.15
The macro is soft deprecated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this note so we can backport this, and then #141033 will add it back (for 3.15 only) once the C API WG approves the deprecation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to backport depreciation, if it will be approved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, deprecations are not backported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of anyone else doing that. Do you know of a deprecation being backported to older versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know of a deprecation being backported to older versions?

E.g.: #124386.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, in that case, I'm fine with backporting #141033, but we should still remove the note from this PR if we want to land it soon, since the C API WG hasn't approved deprecating anything yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with backporting #141033

No, that pr is not going to be backported, only docs here.

we should still remove the note from this PR if we want to land it soon

No need to rush. Lets wait decision. Then we could merge this pr (with or without the deprecation and then, maybe, the #141033 - which might be rejected)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Comment on lines +85 to +87
.. deprecated:: 3.15
The macro is soft deprecated.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. deprecated:: 3.15
The macro is soft deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants