[3.13] gh-100218: correctly set errno when socket.if_{nametoindex,indextoname} raise OSError (GH-140905)
#141285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…index,indextoname}` raise `OSError` (pythonGH-140905) Previously, socket.if_nametoindex() and socket.if_indextoname() could raise an `OSError` with a `None` errno. Now, the errno from libc is propagated. (cherry picked from commit 3ce2d57) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Member
|
MacOS FT errors seem to be unrelated. Should we create a new issue for those? |
Member
Author
|
I think I created or saw an issue somewhere but I know that the IDLE issues always appear on macOS. Could you check this for me please? |
Member
|
I've found this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, socket.if_nametoindex() and socket.if_indextoname() could raise an
OSErrorwith aNoneerrno. Now, the errno from libc is propagated. (cherry picked from commit 3ce2d57)socket.if_nametoindex('no-such-iface')raisesOSError()without settingerrno#100218