gh-136702: Clear codec caches for refleak tests; use test.support helpers #141345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malemburg
reviewed
Nov 10, 2025
| "Support for non-ascii encoding names will be removed in 3.17"): | ||
| msg = "Support for non-ascii encoding names will be removed in 3.17" | ||
| with warnings_helper.check_warnings((msg, DeprecationWarning)): | ||
| self.assertEqual(normalize('utf\xE9\u20AC\U0010ffff-8'), 'utf_8') |
Member
There was a problem hiding this comment.
I think we have to bump the 3.17 to 3.20 if we want to have a 5 year deprecation phase.
Member
Author
There was a problem hiding this comment.
That's up for discussion in the issue; here I'm only unbreaking the buildbots.
encukou
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 0d17ca7 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141345%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
Member
|
Thanks Petr! I encountered this issue with the Android CI, and I though I had it fixed:-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix refleak buildbots.
encodings.normalize_encodingbehaviour or docs #136702